This repository was archived by the owner on Oct 13, 2025. It is now read-only.
Clarkt/bootstrap v4 release upgrade #198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…which includes popper.js
…ctly with bootstrap 4
…clarkt/bootstrap-beta3-upgrade
…clarkt/bootstrap-beta3-upgrade
…clarkt/bootstrap-beta3-upgrade
…clarkt/bootstrap-beta3-upgrade
…ltinn/DesignSystem into clarkt/bootstrap-beta3-upgrade
ghost
reviewed
Mar 26, 2018
| {{# checkboxes }} | ||
|
|
||
| <div class="custom-control {{#isInline}}custom-control-inline{{/isInline}} custom-checkbox a-custom-checkbox {{# inactive }} inactive {{/ inactive }} {{# isDiscreet }} a-form-checkboxes--discret {{/ isDiscreet }}"> | ||
| <input type="checkbox" {{# isChecked }}checked="checked"{{/ isChecked }} class="custom-control-input" {{# data-toggle }} data-toggle="{{ data-toggle }}"{{/ data-toggle }}{{# data-target }} data-target="{{ data-target }}"{{/ data-target }} id="{{checkboxID}}" required {{# inactive }} disabled {{/ inactive }}> |
There was a problem hiding this comment.
Don't we need option to customize it like {{# isRequired }} required {{/ isRequired }} ? This is done in radio button
Contributor
Author
There was a problem hiding this comment.
Yes, I have fixed this.
ghost
reviewed
Mar 26, 2018
| "radio-class": "a-js-feedbackToggle", | ||
| "radiobuttons": [ | ||
| { | ||
| "isInline" : true, |
ghost
reviewed
Mar 26, 2018
| }, | ||
| { | ||
| "additional-classes": "col-3 hidden-sm-down a-list-sortHeader", | ||
| "additional-classes": "col-3 d-none d-sm-block a-list-sortHeader", |
ghost
reviewed
Mar 26, 2018
| }, | ||
| { | ||
| "additional-classes": "col-3 hidden-sm-down a-list-sortHeader", | ||
| "additional-classes": "col-3 d-none d-sm-block a-list-sortHeader", |
ghost
reviewed
Mar 26, 2018
| }, | ||
| { | ||
| "additional-classes": "col-3 hidden-sm-down", | ||
| "additional-classes": "col-3 d-none d-sm-block", |
ghost
reviewed
Mar 26, 2018
| }, | ||
| { | ||
| "additional-classes": "col-3 hidden-sm-down", | ||
| "additional-classes": "col-3 d-none d-sm-block", |
ghost
reviewed
Mar 26, 2018
| "link-class": "a-btn-blue-noUnderline text-right a-fontBold a-fullWidthLink collapsed a-visibleWhenInitial a-hiddenWhenExpanded an-collapse-button pr-0 pr-md-5", | ||
| "link-url": "#", | ||
| "link-text": "<span class='hidden-sm-down'>Utvid</span>", | ||
| "link-text": "<span class='d-none d-sm-block'>Utvid</span>", |
ghost
reviewed
Mar 26, 2018
| "link-class": "a-btn-blue-noUnderline text-right a-fontBold a-fullWidthLink a-visibleWhenExpanded an-collapse-button pr-0 pr-md-5", | ||
| "link-url": "#", | ||
| "link-text": "<span class='hidden-sm-down'>Lukk</span>", | ||
| "link-text": "<span class='d-none d-sm-block'>Lukk</span>", |
ghost
reviewed
Mar 26, 2018
| }, | ||
| { | ||
| "additional-classes": "col-3 hidden-sm-down", | ||
| "additional-classes": "col-3 d-none d-sm-block", |
ghost
reviewed
Mar 26, 2018
| }, | ||
| { | ||
| "additional-classes": "col-3 hidden-sm-down", | ||
| "additional-classes": "col-3 d-none d-sm-block", |
There was a problem hiding this comment.
d-md-block, in all the places in this file. I suspect this is probably done with purpose?
ghost
reviewed
Mar 26, 2018
| @import './../../node_modules/bootstrap/scss/type'; | ||
| @import './../../node_modules/bootstrap/scss/images'; | ||
| /*@import './../../node_modules/bootstrap/scss/code';*/ | ||
| // @import './../../node_modules/bootstrap/scss/code'; |
ghost
reviewed
Mar 26, 2018
| @import './../../node_modules/bootstrap/scss/badge'; | ||
| @import './../../node_modules/bootstrap/scss/jumbotron'; | ||
| /*@import './../../node_modules/bootstrap/scss/alert';*/ | ||
| // @import './../../node_modules/bootstrap/scss/alert'; |
ghost
reviewed
Mar 26, 2018
| /*@import './../../node_modules/bootstrap/scss/carousel';*/ | ||
|
|
||
| // Utility classes | ||
| // @import './../../node_modules/bootstrap/scss/carousel'; |
ghost
reviewed
Mar 26, 2018
| // Reset and dependencies | ||
| // @import './../../node_modules/bootstrap/scss/normalize'; | ||
| // @import './../../node_modules/bootstrap/scss/print'; | ||
|
|
ghost
reviewed
Mar 26, 2018
| display: block; | ||
|
|
||
| .custom-radio { | ||
| .a-radioButtons-excerpt { |
There was a problem hiding this comment.
Should we also change the name 'custom-radio' in line 674 to 'a-radiobuttons-excerpt'?
ghost
reviewed
Mar 26, 2018
| display: inline-block; | ||
| margin-right: $spacer * 2; | ||
| } | ||
| .custom-control-input { |
There was a problem hiding this comment.
just wondering if we should change 'custom-control' to 'custom-control-input' in line 696 as well?
acn-dgopa
approved these changes
Mar 27, 2018
Member
acn-dgopa
left a comment
acn-dgopa
left a comment
There was a problem hiding this comment.
I think we can merge and fix those comments if they are something to be fixed
I have commented on some of the changes on another login which i noticed later.
My observations:
- Few class names (like custom-control) seem to be not updated both in css files and mustache files but i also suspect that it might be on purpose
- Checkbox and radio buttons seem to be not functioning properly sometimes, f.eks, when i click it doesnt get selected, this happens sometimes
…nged some d-sm-block to d-md-block
acn-dgopa
approved these changes
Apr 6, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Oppdatering til releaseversjon av bootstrap 4