Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for UNKNOWN DATABASE exception #344

Merged
merged 9 commits into from
Nov 1, 2023
Merged
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

public class ClickHouseCreateDatabase extends ClickHouseTableOperationsBase {
public void createNewDatabase(ClickHouseConnection conn, String dbName) throws SQLException {
this.runQuery(String.format("CREATE DATABASE %s", dbName), conn);
String query = String.format("USE system; CREATE DATABASE IF NOT EXISTS %s; USE %s", dbName, dbName);
this.runQuery(query, conn);
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,69 @@
package com.altinity.clickhouse.sink.connector.db.operations;

import com.altinity.clickhouse.sink.connector.ClickHouseSinkConnectorConfig;
import com.clickhouse.jdbc.ClickHouseConnection;
import com.clickhouse.jdbc.ClickHouseDataSource;
import com.altinity.clickhouse.sink.connector.db.DbWriter;
import org.junit.Assert;
import org.testcontainers.junit.jupiter.Testcontainers;
import org.testcontainers.junit.jupiter.Container;
import org.junit.jupiter.api.BeforeAll;
import org.junit.jupiter.api.Test;
import org.testcontainers.containers.ClickHouseContainer;
import org.apache.commons.lang3.StringUtils;

import java.sql.ResultSet;
import java.sql.SQLException;
import java.sql.Statement;
import java.util.Properties;
import java.util.ArrayList;
import java.util.HashMap;

@Testcontainers

public class ClickHouseCreateDatabaseTest {

static DbWriter dbWriter;
static DbWriter maintenanceDbWriter;
static String dbName;

@Container
private ClickHouseContainer clickHouseContainer = new ClickHouseContainer("clickhouse/clickhouse-server:latest")
.withInitScript("./init_clickhouse.sql");;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra semicolon

@BeforeAll
static void initialize() {

String hostName = "localhost";
Integer port = 8123;
String userName = "root";
String password = "root";
String systemDb = "system";
dbName = "test_create_db";

ClickHouseSinkConnectorConfig config= new ClickHouseSinkConnectorConfig(new HashMap<>());
dbWriter = new DbWriter(hostName, port, dbName, null, userName, password, config, null);
maintenanceDbWriter = new DbWriter(hostName, port, systemDb, null, userName, password, config, null);
}

@Test
public void testCreateNewDatabase() throws SQLException {
this.dropTestDatabase(dbName);
ClickHouseCreateDatabase act = new ClickHouseCreateDatabase();
ClickHouseConnection conn = dbWriter.getConnection();
try {
act.createNewDatabase(conn, dbName);
} catch(SQLException se) {
//System.out.println(se.getMessage());
Assert.assertTrue(false);
}
Statement stmt = dbWriter.getConnection().createStatement();
String query = String.format("SELECT name FROM system.databases WHERE name = '%s'", dbName);
ResultSet rs = stmt.executeQuery(query);
Assert.assertTrue(rs.next());
}

public void dropTestDatabase(String db) throws SQLException {
Statement drop = maintenanceDbWriter.getConnection().createStatement();
drop.executeQuery(String.format("DROP DATABASE IF EXISTS %s", db));
}
}
Loading