Skip to content

Refactor stsSetupHostAliases for conditional host aliases #1895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
HighWatersDev wants to merge 1 commit into
base: 0.26.0
Choose a base branch
from
+19 −9
Open

Refactor stsSetupHostAliases for conditional host aliases #1895

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 19 additions & 9 deletions pkg/model/common/creator/stateful-set-application.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,21 +119,31 @@ func (c *Creator) stsEnsureAppContainerProbesSpecified(statefulSet *apps.Statefu

// stsSetupHostAliases
func (c *Creator) stsSetupHostAliases(statefulSet *apps.StatefulSet, host *api.Host) {
var aliases []core.HostAlias

// Ensure pod created by this StatefulSet has alias 127.0.0.1
statefulSet.Spec.Template.Spec.HostAliases = []core.HostAlias{
{
IP: "127.0.0.1",
// Only add if there's a valid hostname
podHostname := c.nm.Name(interfaces.NamePodHostname, host)
if podHostname != "" {
aliases = append(aliases, core. HostAlias{
IP: "127.0.0.1",
Hostnames: []string{
c.nm.Name(interfaces.NamePodHostname, host),
podHostname,
},
},
})
}

// Add hostAliases from PodTemplate if any
if podTemplate, ok := host.GetPodTemplate(); ok {
statefulSet.Spec.Template.Spec.HostAliases = append(
statefulSet.Spec.Template.Spec.HostAliases,
podTemplate.Spec.HostAliases...,
)
aliases = append(aliases, podTemplate. Spec.HostAliases...)
}

// Only set hostAliases if we have any; otherwise leave it nil (unset)
if len(aliases) > 0 {
statefulSet.Spec.Template.Spec.HostAliases = aliases
} else {
// Explicitly unset to comply with Gatekeeper policy
statefulSet.Spec.Template.Spec.HostAliases = nil
}
}

Expand Down