Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added search #609

Merged
merged 6 commits into from
Mar 2, 2022
Merged

added search #609

merged 6 commits into from
Mar 2, 2022

Conversation

DrMagPie
Copy link
Collaborator

@DrMagPie DrMagPie commented Jan 24, 2022 •
edited
Loading

@DrMagPie
Copy link
Collaborator Author

DrMagPie commented Feb 3, 2022 •
edited
Loading

Here are some options how we can integrate this search page:

  1. Home Page
  2. Footer
  3. Header

you can find code here: https://github.com/DrMagPie/Alt-F4/pulls

Looks like 3rd option breaks mobile version, and needs a bit more tinkering with css.

DrMagPie and others added 2 commits February 19, 2022 20:53
@DrMagPie
first option to integrate search (#8)
d0c0f34 
* first option to integrate search

* reworked first option
@DrMagPie
Changed input type to remove clear button
449d04a
Conor12345
Conor12345 approved these changes Feb 25, 2022
View reviewed changes
Copy link
Member

@Conor12345 Conor12345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work as always magpie! Looks great and seems to work really well!

heinwessels
heinwessels approved these changes Mar 2, 2022
View reviewed changes
Copy link
Contributor

@heinwessels heinwessels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome DrMagPie! Thanks for the continued work you put into this project :)

@DrMagPie DrMagPie merged commit 6110e74 into AlternativeFFFF:master Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Conor12345 Conor12345 Conor12345 approved these changes

@heinwessels heinwessels heinwessels approved these changes

Assignees
No one assigned
Labels
impact:enhancement New feature or request platform:website
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DrMagPie @Conor12345 @heinwessels