Fix thread leak with 0 regions and settings applied #888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e or applying settings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an thread leak in an usual case where:
The most likely way this could affect users of this library is by leaving BackgroundPowerSaver enabled on Android 8+ when the app is not ranging and monitoring any regions.
This happened because the ScanJob code failed to stop all the threads on CycledLeScanner by calling destroy() in the case where a ScanJob was abandoned because the BLE scan did not start. And the BLE scan did not start (by design) if the number of regions monitored and ranged were 0.
This change also adds code to the ScanJobScheduler that cancels all scheduled ScanJobs if there are 0 regions monitored and ranged. It is pointless and wasteful to keep the jobs going in this case.