Merge pull request #828 from AltBeacon/fix-crash-on-starting-foregrou…

…nd-service Fix crash on scanning as foreground service
AltBeacon · Feb 10, 2019 · 9f5a6a6 · 9f5a6a6
2 parents 091d499 + 411d058
commit 9f5a6a6
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,7 @@
 ### Development
 
+- Fix crash on starting scanning with a forground service configured when multiple BeaconConsumer
+  instances bound.  (#828, David G. Young)
 - Fix broken RegionBoostrap callbacks caused by change in previous release (#829, David G. Young)
 
 ### 2.16 / 2019-02-10

diff --git a/lib/src/main/java/org/altbeacon/beacon/BeaconManager.java b/lib/src/main/java/org/altbeacon/beacon/BeaconManager.java
@@ -429,8 +429,14 @@ public void bind(@NonNull BeaconConsumer consumer) {
                     Intent intent = new Intent(consumer.getApplicationContext(), BeaconService.class);
                     if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O &&
                             this.getForegroundServiceNotification() != null) {
-                        LogManager.i(TAG, "Starting foreground beacon scanning service.");
-                        mContext.startForegroundService(intent);
+                        if (isAnyConsumerBound()) {
+                            LogManager.i(TAG, "Not starting foreground beacon scanning" +
+                                    " service.  A consumer is already bound, so it should be started");
+                        }
+                        else {
+                            LogManager.i(TAG, "Starting foreground beacon scanning service.");
+                            mContext.startForegroundService(intent);
+                        }
                     }
                     else {
                     }