Jannat/refactor/505 leaderboard clan pages #516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should fix the keyword responsible for automated closing of issue linked to PR
…ports and layout complexity
JannatBiva
requested review from
leolabdev,
MikhailDeriabin,
Skoivumaki,
kaisahakola and
Rutjake
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 Overview
Implements the enhancements requested in Issue #505 by refactoring Clan and Leaderboard pages, integrating new API endpoints, and improving layout/navigation consistency.
🔧 Changes Made
leaderboardApi.tswith Swagger-documented endpoints:GET /leaderboard/playerGET /leaderboard/clanGET /leaderboard/clan/position(handles 404 for "not in clan")leaderboardResponses.tswith TypeScript interfaces for API responses.LeaderboardClans.tsxto use new API calls instead of old queries.ClanPositionStatuscomponent with SCSS styles.LeaderboardLayoutfor full-width desktop display.ClanLayoutnavigation to point to/leaderboard.leaderboard.json,navbar.json).✅ Checklist
📎 References
Closes #505
Swagger docs and design references provided in the issue.
Screenshots