Skip to content

Idrees/enhancement/437 update join us page #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

Idreesyaser
Copy link

📄 Pull Request Overview

Closes #437
Implements the fully responsive "Join Us" page based on the provided Figma design. This includes layout structure, styling, localization, dynamic content blocks, and automated tests.

🔧 Changes Made

  1. Update Page: Update JoinUsPage with six dynamically generated content blocks (Discord, Contact, Feedback, etc.)

  2. Block Component: Implemented a reusable component to render image, label, description, and one or more links.

  3. Localization (i18n): Populated join-us.json for both fi and en locales with translated labels, descriptions, and links.

  4. Assets: Added new image and icon assets for each block (stored under shared/assets/images and shared/assets/icons).

  5. Styling: Created modular SCSS files for layout and individual blocks with support for responsiveness and accessibility.

  6. Testing: Added unit tests for:

      Block rendering
    
      Page layout
    
      i18n generation function (makeJoinUsBlocks)
    
  7. Storybook: Updated Storybook stories for the Block component and JoinUsPage for visual documentation.


Checklist Before Submission

  • [✅] Functionality: Tested all blocks and responsive layout on Chrome and Firefox
  • [✅] JSDoc: Added JSDoc to major helper functions and components
  • [✅] Debugging: Removed all temporary console.log() statements
  • [✅] Clean Code: Removed unused imports and commented-out code
  • [✅] Tests: All related test suites pass (jest, @testing-library/react)
  • [✅] Documentation: Documentation has been updated

📝 Additional Information

Provide any additional context or information that reviewers may need to know:
Näyttökuva 2025-05-02 182752

  • Dependencies: No new packages or dependencies added
  • Known Issues: Current layout uses a manual marginTop workaround to handle sticky navbar. A more robust solution could be implemented later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant