Jari/enhancement/425 update login component and language switcher #451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leaving the animation issue and other fixes for later
…nd-language-switcher
jartsanull
requested review from
leolabdev,
MikhailDeriabin,
Jonroi,
Skoivumaki and
kaisahakola
as code owners
|
Forgot to send a picture of the result:
|
|
Other languages are using three letters so would it look better If Russian is also written as RUS?
LähetettyOutlook for Android<https://aka.ms/AAb9ysg>
…________________________________
From: null ***@***.***>
Sent: Thursday, April 24, 2025 5:02:43 PM
To: Alt-Org/Altzone-WebPages ***@***.***>
Cc: Joni Roine ***@***.***>; Review requested ***@***.***>
Subject: Re: [Alt-Org/Altzone-WebPages] Jari/enhancement/425 update login component and language switcher (PR #451)
[https://avatars.githubusercontent.com/u/151707803?s=20&v=4]jartsanull left a comment (Alt-Org/Altzone-WebPages#451)<#451 (comment)>
Forgot to send a picture of the result:
image.png (view on web)<https://github.com/user-attachments/assets/9345cdeb-7011-4564-b64a-5b55b4d4c268>
—
Reply to this email directly, view it on GitHub<#451 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BB5BVRLTOTOGIER66SQOTTL23DVIHAVCNFSM6AAAAAB3ZBHAZCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMRXG42DGNBXG4>.
You are receiving this because your review was requested.Message ID: ***@***.***>
|
|
Done! I fixed the abbreviation! Edit: |
|
Now officially fixed |
Skoivumaki
requested changes
Apr 28, 2025
There was a problem hiding this comment.
Can you enlarge the clickable area of the language switcher to also include the text (not just the SVG)?
When opening the navmenu the first time, the language switcher shouldnt be open by default.
Edited comment since I forgot Figma exists.
Do following:
- When opening the navmenu the first time, the language switcher shouldnt be open by default. (we have limited space on smaller devices, language switcher being open on default doenst help the bloat)
- Extend the clickable area of the language switcher to also include the text (not just the SVG)
There was a problem hiding this comment.
why were these changes made and are you sure they wont cause problems?
There was a problem hiding this comment.
From, what I understood, they are linked to the code editor WebStorm. I don't know why I have these folders. We can check them out on the call if you want.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 Pull Request Overview
Closes #425
🔧 Changes Made
As we agreed, I completed the part of the language switcher. I added the new language (Russian) and did the design changes accordig to Figma.
✅ Checklist Before Submission
console.log()or other debugging statements are left.📝 Additional Information
Provide any additional context or information that reviewers may need to know: