Skip to content

Conversation

JamesSmartCell
Copy link
Member

@JamesSmartCell JamesSmartCell commented Dec 15, 2022

Several fixes to close most of #2992:

  • Boolean return from Attribute isn't working correctly.
  • name and label in token props should represent the blockchain name() and the TokenScript label respectively.
  • numeric values do not need to wrapped in quotes unless they are hex.
  • boolean attributes should be lowercase true or false without quotes.
  • Ensure attributes are updated correctly.

closes #2992

@github-actions
Copy link

Pull reviewers stats

Stats of the last 30 days for alpha-wallet-android:

User Total reviews Time to review Total comments
JamesSmartCell
🥇
13
▀▀▀▀▀▀▀
12h 20m
▀▀▀▀▀▀▀
5
▀▀▀▀▀▀
seabornlee
🥈
4
▀▀
1h 44m
3
▀▀▀▀
justindg
🥉
2
2h 29m
▀▀
0

@codecov
Copy link

codecov bot commented Dec 15, 2022

Codecov Report

Base: 7.64% // Head: 7.76% // Increases project coverage by +0.11% 🎉

Coverage data is based on head (c381a7e) compared to base (9387cd0).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##             master   #3009      +/-   ##
===========================================
+ Coverage      7.64%   7.76%   +0.11%     
- Complexity      869     890      +21     
===========================================
  Files           640     641       +1     
  Lines         43006   43108     +102     
  Branches       4330    4348      +18     
===========================================
+ Hits           3289    3347      +58     
- Misses        39439   39472      +33     
- Partials        278     289      +11     
Impacted Files Coverage Δ
...et/app/entity/tokenscript/TokenscriptFunction.java 0.63% <0.00%> (ø)
...lphawallet/app/service/AssetDefinitionService.java 6.04% <0.00%> (-0.08%) ⬇️
.../java/com/alphawallet/app/ui/FunctionActivity.java 0.00% <0.00%> (ø)
.../main/java/com/alphawallet/app/ui/NFTActivity.java 0.00% <0.00%> (ø)
...ain/java/com/alphawallet/app/ui/TokenActivity.java 0.00% <0.00%> (ø)
...va/com/alphawallet/app/viewmodel/NFTViewModel.java 0.00% <0.00%> (ø)
.../com/alphawallet/app/widget/FunctionButtonBar.java 0.00% <0.00%> (ø)
...allet/app/walletconnect/AWWalletConnectClient.java 6.85% <0.00%> (-0.08%) ⬇️
...main/java/com/alphawallet/app/ui/HomeActivity.java 2.35% <0.00%> (-0.04%) ⬇️
... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@JamesSmartCell JamesSmartCell merged commit fa1c344 into master Dec 18, 2022
@JamesSmartCell JamesSmartCell deleted the optimise-tokenscript-conditionals branch December 18, 2022 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix outstanding issues in TokenScript

1 participant