Skip to content

Conversation

JamesSmartCell
Copy link
Member

Closes #2842

@github-actions
Copy link

Pull reviewers stats

Stats of the last 30 days for alpha-wallet-android:

User Total reviews Time to review Total comments
JamesSmartCell
🥇
13
▀▀▀▀▀▀▀
12h 20m
▀▀▀▀▀
6
▀▀▀▀▀▀▀
seabornlee
🥈
6
▀▀▀
9h 27m
▀▀▀▀
3
▀▀▀
justindg
🥉
1
4h 56m
▀▀
0

@codecov
Copy link

codecov bot commented Dec 11, 2022

Codecov Report

Base: 7.64% // Head: 7.64% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (a77f6ba) compared to base (808930c).
Patch coverage: 2.85% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##             master   #3002      +/-   ##
===========================================
- Coverage      7.64%   7.64%   -0.01%     
  Complexity      869     869              
===========================================
  Files           640     640              
  Lines         43006   43031      +25     
  Branches       4330    4341      +11     
===========================================
  Hits           3289    3289              
- Misses        39439   39464      +25     
  Partials        278     278              
Impacted Files Coverage Δ
app/src/main/java/com/alphawallet/app/C.java 57.14% <ø> (ø)
...va/com/alphawallet/app/service/OpenSeaService.java 6.73% <0.00%> (-0.92%) ⬇️
...wallet/app/ui/widget/adapter/NFTAssetsAdapter.java 0.00% <0.00%> (ø)
...lphawallet/app/repository/EthereumNetworkBase.java 46.21% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@JamesSmartCell JamesSmartCell requested a review from hboon December 23, 2022 12:02
Copy link
Member

@hboon hboon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presume you tested, especially for v2 :)

@JamesSmartCell JamesSmartCell merged commit ee0d074 into master Dec 24, 2022
@JamesSmartCell JamesSmartCell deleted the add-additional-opensea-chains branch December 24, 2022 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Check out chains supported by OpenSea API and let's

2 participants