Skip to content

Conversation

JamesSmartCell
Copy link
Member

  • Normalise formatting in AssetDefinitionService
  • Small refactor and add unit test

@github-actions
Copy link

github-actions bot commented Sep 1, 2022

Pull reviewers stats

Stats of the last 30 days for alpha-wallet-android:

User Total reviews Time to review Total comments
JamesSmartCell
🥇
9
▀▀▀▀▀
20h 27m
▀▀▀
13
▀▀▀▀▀▀▀
seabornlee
🥈
7
▀▀▀▀
2h 19m
7
▀▀▀▀
justindg
🥉
1
1d 19h 5m
▀▀▀▀▀▀▀
0

@codecov
Copy link

codecov bot commented Sep 1, 2022

Codecov Report

Base: 7.41% // Head: 7.41% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (f5e71b2) compared to base (5746c1e).
Patch coverage: 4.59% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff            @@
##             master   #2797   +/-   ##
========================================
  Coverage      7.41%   7.41%           
  Complexity      779     779           
========================================
  Files           575     575           
  Lines         40601   40624   +23     
  Branches       4133    4133           
========================================
+ Hits           3011    3014    +3     
- Misses        37334   37354   +20     
  Partials        256     256           
Impacted Files Coverage Δ
.../src/main/java/com/alphawallet/app/util/Utils.java 9.06% <0.00%> (ø)
...lphawallet/app/service/AssetDefinitionService.java 6.13% <4.70%> (+0.12%) ⬆️
...va/com/alphawallet/app/service/OpenSeaService.java 7.60% <0.00%> (ø)
...va/com/alphawallet/app/ui/ImportTokenActivity.java 0.00% <0.00%> (ø)
...llet/app/repository/EthereumNetworkRepository.java 16.66% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@seabornlee seabornlee merged commit b00f655 into master Sep 2, 2022
@seabornlee seabornlee deleted the add-IPFS-EIP5169-uinttest branch September 2, 2022 12:20
seabornlee pushed a commit that referenced this pull request Sep 8, 2022
* small refactor and add unit test

* Wait for token

* Change timeout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants