Skip to content

Conversation

justindg
Copy link
Contributor

@github-actions
Copy link

Pull reviewers stats

Stats of the last 30 days for alpha-wallet-android:

User Total reviews Time to review Total comments
JamesSmartCell
🥇
5
▀▀▀▀▀▀
1d 16h 18m
▀▀▀▀▀▀▀▀▀
5
▀▀▀▀▀▀▀▀▀▀
seabornlee
🥈
4
▀▀▀▀
3h 13m
0

@codecov
Copy link

codecov bot commented Aug 25, 2022

Codecov Report

Base: 7.25% // Head: 7.36% // Increases project coverage by +0.10% 🎉

Coverage data is based on head (7fd03be) compared to base (045a95a).
Patch coverage: 26.63% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##             master   #2781      +/-   ##
===========================================
+ Coverage      7.25%   7.36%   +0.10%     
- Complexity      759     773      +14     
===========================================
  Files           568     575       +7     
  Lines         40415   40554     +139     
  Branches       4120    4127       +7     
===========================================
+ Hits           2932    2985      +53     
- Misses        37232   37314      +82     
- Partials        251     255       +4     
Impacted Files Coverage Δ
app/src/main/java/com/alphawallet/app/C.java 57.14% <ø> (ø)
...ava/com/alphawallet/app/di/RepositoriesModule.java 92.00% <0.00%> (-3.84%) ⬇️
...alphawallet/app/repository/KeyProviderJNIImpl.java 0.00% <ø> (ø)
...main/java/com/alphawallet/app/ui/BaseActivity.java 30.76% <0.00%> (-0.61%) ⬇️
...va/com/alphawallet/app/ui/CoinbasePayActivity.java 0.00% <0.00%> (ø)
...in/java/com/alphawallet/app/ui/WalletFragment.java 1.96% <0.00%> (-0.05%) ⬇️
...lphawallet/app/viewmodel/CoinbasePayViewModel.java 0.00% <0.00%> (ø)
...com/alphawallet/app/viewmodel/WalletViewModel.java 21.65% <33.33%> (+0.22%) ⬆️
.../com/alphawallet/app/widget/BuyEthOptionsView.java 65.00% <65.00%> (ø)
.../com/alphawallet/app/router/CoinbasePayRouter.java 66.66% <66.66%> (ø)
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@justindg
Copy link
Contributor Author

I removed Coinbase Pay App ID for now, should we add it to our keys? From what I see, it is not really sensitive. If you use Coinbase Pay via Metamask, you can see the app id from the browser bar. But I'm leaving the decision to you @seabornlee @JamesSmartCell :)

@JamesSmartCell
Copy link
Member

Hi @justindg do you need the salting tool to create the key?

@justindg
Copy link
Contributor Author

Hi @justindg do you need the salting tool to create the key?

Hi James, if we decide to include it in keys, then I think yes. How do I access it?

@JamesSmartCell
Copy link
Member

Hi @justindg do you need the salting tool to create the key?

Hi James, if we decide to include it in keys, then I think yes. How do I access it?

I haven't added it to github yet. I'll check it in. However you'll probably want the command line tool, it's easy to use just > obfuscator . Actually it's C++, not sure how to make a mac executable, but it should be straightforward using gcc.

@JamesSmartCell JamesSmartCell merged commit 0b918fe into master Aug 31, 2022
@JamesSmartCell JamesSmartCell deleted the coinbase-pay branch August 31, 2022 05:56
seabornlee pushed a commit that referenced this pull request Sep 8, 2022
* Allow users to buy assets with Coinbase Pay
* Remove unused methods/tests
* Update test
* Add router test
* Move Coinbase Pay App ID to keys
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow purchase of crypto assets via Coinbase Pay
3 participants