-
Notifications
You must be signed in to change notification settings - Fork 561
Allow users to purchase assets via Coinbase Pay #2781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
justindg
commented
Aug 25, 2022
- Closes Allow purchase of crypto assets via Coinbase Pay #2775
Pull reviewers statsStats of the last 30 days for alpha-wallet-android:
|
Codecov ReportBase: 7.25% // Head: 7.36% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2781 +/- ##
===========================================
+ Coverage 7.25% 7.36% +0.10%
- Complexity 759 773 +14
===========================================
Files 568 575 +7
Lines 40415 40554 +139
Branches 4120 4127 +7
===========================================
+ Hits 2932 2985 +53
- Misses 37232 37314 +82
- Partials 251 255 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
I removed Coinbase Pay App ID for now, should we add it to our keys? From what I see, it is not really sensitive. If you use Coinbase Pay via Metamask, you can see the app id from the browser bar. But I'm leaving the decision to you @seabornlee @JamesSmartCell :) |
app/src/androidTest/java/com/alphawallet/app/CoinbasePayTest.java
Outdated
Show resolved
Hide resolved
app/src/main/java/com/alphawallet/app/entity/coinbasepay/DestinationWallet.java
Outdated
Show resolved
Hide resolved
app/src/main/java/com/alphawallet/app/util/CoinbasePayUtils.java
Outdated
Show resolved
Hide resolved
app/src/test/java/com/alphawallet/app/repository/CoinbasePayRepositoryTest.java
Outdated
Show resolved
Hide resolved
Hi @justindg do you need the salting tool to create the key? |
Hi James, if we decide to include it in keys, then I think yes. How do I access it? |
I haven't added it to github yet. I'll check it in. However you'll probably want the command line tool, it's easy to use just > obfuscator . Actually it's C++, not sure how to make a mac executable, but it should be straightforward using gcc. |
* Allow users to buy assets with Coinbase Pay * Remove unused methods/tests * Update test * Add router test * Move Coinbase Pay App ID to keys