Skip to content

WalletConnect v2 issue list #2963

@JamesSmartCell

Description

@JamesSmartCell

All of these are pretty much superficial - the core works amazingly well :)

Essential:

  • Warn user if WalletRequest sign/TX send is for a different wallet than the current default wallet.
  • When connecting WalletConnect dialog should not show watch wallets
  • When connecting WalletConnect dialog should only show default wallet (?) and ask for connection permission. This permission, once granted should be remembered.
  • If addresses are shown, use Utils.formatAddress(...)
    - [ ] If WalletConnect message is received while user is not on the home pages (wallet/activity/browser/settings) use the notification - add the numbering (or see what that looks like). (Moved to WalletConnect signing prompts not showing from some screens #2985)

Optional (but great if they can be done):

- [ ] If user cancels the signing dialog in the browser, close the open ActionSheet on the app (Moved to #2986 )
- [ ] I got this crash occasionally when disconnecting a WC2 session from the desktop end: (Moved to #2987)

java.lang.IndexOutOfBoundsException: Inconsistency detected. Invalid item position 2(offset:-1).state:19 androidx.recyclerview.widget.RecyclerView{5fed730 VFED..... ......ID 0,0-1080,2085 #7f0a029e app:id/list}, adapter:com.alphawallet.app.ui.widget.adapter.TokensAdapter@b7dda7f, layout:androidx.recyclerview.widget.LinearLayoutManager@a62ea4c, context:dagger.hilt.android.internal.managers.ViewComponentManager$FragmentContextWrapper@a5120b4

Metadata

Metadata

Assignees

Labels

Free for allAny team can pick up this task, if have exhausted task stack or needing a break

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions