Repository navigation
Conversation
frezcirno
marked this pull request as ready for review
September 29, 2026 09:48
frezcirno
requested review from
ishaan-arya,
kunal-mansukhani and
shxjames
as code owners
September 29, 2026 09:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Max Subarray Sum reference loses the first window when it is the unique maximum. For example,
input=[9, -8],N=2,window_size=1currently produces-8instead of9, so a correct solution can be rejected.max_sum = current_sumaliases the same scalar Tensor. The first in-place sliding-window update changes both values beforetorch.maxcan preserve the original maximum. Clone the initial sum to keep it independent. Add functional regressions for positive, negative, and multi-element first-window maxima, plus the single-window boundary (window_size == N).Validation:
python scripts/validate_challenges.py: 101 challenges, zero errors; two existing warnings about unrelated challenge directories/starters.git diff --checkpasses.