fix(desktop): remove duplicate tray icon config#801
Open
Conversation
added 2 commits
January 16, 2026 16:06
The desktop app was showing 'Something went wrong' because NEXT_PUBLIC_PRIVY_APP_ID was not set during the build. Added required environment variables from secrets.
The tray icon was being created twice - once by the trayIcon config in tauri.conf.json and once programmatically in lib.rs setup_tray(). This caused two Gatewayz icons to appear in the Windows taskbar. Removed the config since the code handles it.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the issue where two Gatewayz icons appear in the Windows taskbar.
Root Cause
The tray icon was being created twice:
trayIconconfig intauri.conf.jsonlib.rssetup_tray()functionFix
Removed the
trayIconconfig fromtauri.conf.jsonsince the Rust code already handles tray icon creation with the proper menu and event handlers.Test plan
🤖 Generated with Claude Code
Greptile Summary
This PR fixes a duplicate tray icon issue on Windows by removing the declarative
trayIconconfiguration fromtauri.conf.json. The tray icon is now created exclusively through the programmaticsetup_tray()function insrc-tauri/src/lib.rs:144, which provides the proper menu items and event handlers.Key Changes:
trayIconconfig fromtauri.conf.jsonthat was creating the first duplicate iconNEXT_PUBLIC_PRIVY_APP_ID,NEXT_PUBLIC_API_BASE_URL, andNEXT_PUBLIC_CHAT_HISTORY_API_URLenvironment variables to the desktop build workflow (these are required for authentication to work)How it Works:
The Rust code at
lib.rs:144-230already handles complete tray icon setup including the icon, menu items (Show, New Chat, Check Updates, Settings, Quit), keyboard shortcuts, and click event handlers. The declarative config was redundant and causing Tauri to create a second icon without the custom menu.Confidence Score: 5/5
Important Files Changed
Sequence Diagram
sequenceDiagram participant App as Tauri App Startup participant Config as tauri.conf.json participant Rust as lib.rs setup_tray() participant Tray as System Tray Note over App,Config: BEFORE (Duplicate Icons) App->>Config: Read trayIcon config Config->>Tray: Create tray icon #1 App->>Rust: Call setup() Rust->>Tray: Create tray icon #2 Note over Tray: Two icons appear! Note over App,Config: AFTER (Single Icon) App->>Config: Read config (no trayIcon) App->>Rust: Call setup() Rust->>Tray: Create tray icon with menu Note over Tray: One icon with full functionality