[Python-package]: Fix RandomState issue microsoft#376 (microsoft#377)

* Python: Fix RandomState issue microsoft#376 * Add test case for Python's Shuffle=True
Alnusjaponica · Apr 2, 2017 · 21861cd · 21861cd
1 parent 945bc15
commit 21861cd
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/python-package/lightgbm/engine.py b/python-package/lightgbm/engine.py
@@ -236,7 +236,7 @@ def _make_n_folds(full_data, data_splitter, nfold, params, seed, fpreproc=None,
         folds = sfk.split(X=np.zeros(num_data), y=full_data.get_label())
     else:
         if shuffle:
-            randidx = np.RandomState(seed).random.permutation(num_data)
+            randidx = np.random.RandomState(seed).permutation(num_data)
         else:
             randidx = np.arange(num_data)
         kstep = int(num_data / nfold)

diff --git a/tests/python_package_test/test_engine.py b/tests/python_package_test/test_engine.py
@@ -149,6 +149,9 @@ def test_cv(self):
         lgb.cv({'verbose': -1}, lgb_train, num_boost_round=20, nfold=5, shuffle=False,
                metrics='l1', verbose_eval=False,
                callbacks=[lgb.reset_parameter(learning_rate=lambda i: 0.1 - 0.001 * i)])
+        lgb.cv({'verbose': -1}, lgb_train, num_boost_round=20, nfold=5, shuffle=True,
+               metrics='l1', verbose_eval=False,
+               callbacks=[lgb.reset_parameter(learning_rate=lambda i: 0.1 - 0.001 * i)])
         tss = TimeSeriesSplit(3)
         lgb.cv({'verbose': -1}, lgb_train, num_boost_round=20, data_splitter=tss, nfold=5,  # test if wrong nfold is ignored
                metrics='l2', verbose_eval=False)