Skip to content

feat: added a particle callback function that will be executed when the particle is removed #1286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 28, 2023

Conversation

wonderfulLand
Copy link
Contributor

I think this function is still necessary.

@AlmasB
Copy link
Owner

AlmasB commented Nov 1, 2023

Hi, thanks for this. Please can you provide a use case example.

@wonderfulLand
Copy link
Contributor Author

Hi, thanks for this. Please can you provide a use case example.

https://www.bilibili.com/video/BV1iz4y1s7WW/?spm_id_from=333.337.search-card.all.click&vd_source=33227c9937f8f5c6629d4a8cb0e5be97
The URL above is a small demo. The raindrops in the video are simulated using a particle system. When raindrops fall onto the surface of the lake, they can cause ripples.

@DeathPhoenix22
Copy link
Contributor

Hi,
I was thinking of doing this! If it gets in the Engine, thanks for it :)

@AlmasB AlmasB changed the title Add a particle function that will be executed when the particle is removed. feat: added a particle callback function that will be executed when the particle is removed Dec 28, 2023
@AlmasB
Copy link
Owner

AlmasB commented Dec 28, 2023

@wonderfulLand Thanks for clarifying. I've just made a few editorial changes to maintain consistency. It's all merged now.

@codecov-commenter
Copy link

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (cb70500) 59.52% compared to head (e151899) 59.73%.
Report is 32 commits behind head on dev.

Files Patch % Lines
...java/com/almasb/fxgl/particle/ParticleEmitter.java 40.00% 3 Missing ⚠️
...tlin/com/almasb/fxgl/particle/ParticleComponent.kt 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #1286      +/-   ##
============================================
+ Coverage     59.52%   59.73%   +0.20%     
- Complexity     2953     2961       +8     
============================================
  Files           308      308              
  Lines         15197    15256      +59     
  Branches       1558     1556       -2     
============================================
+ Hits           9046     9113      +67     
+ Misses         5628     5622       -6     
+ Partials        523      521       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlmasB AlmasB merged commit f3b52e3 into AlmasB:dev Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants