Skip to content

test: added matrix 3x3 test #1258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 28, 2023
Merged

test: added matrix 3x3 test #1258

merged 2 commits into from
Mar 28, 2023

Conversation

Mageconvict
Copy link
Contributor

No description provided.

Copy link
Contributor Author

@Mageconvict Mageconvict left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Window header UI text scaling needs to be implemented in: src/main/kotlin/com/almasb/fxgl/ui/MDIWindow.kt

At line: 163.

@codecov-commenter
Copy link

Codecov Report

Merging #1258 (2fc1c94) into dev (6702081) will increase coverage by 0.00%.
The diff coverage is 60.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff            @@
##                dev    #1258   +/-   ##
=========================================
  Coverage     58.74%   58.75%           
  Complexity     2937     2937           
=========================================
  Files           304      304           
  Lines         15046    15050    +4     
  Branches       1540     1540           
=========================================
+ Hits           8839     8842    +3     
- Misses         5700     5701    +1     
  Partials        507      507           
Impacted Files Coverage Δ
...almasb/fxgl/ui/FXGLDialogFactoryServiceProvider.kt 0.00% <0.00%> (ø)
...gl/src/main/kotlin/com/almasb/fxgl/app/Settings.kt 90.15% <100.00%> (+0.11%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Owner

@AlmasB AlmasB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@AlmasB AlmasB merged commit 74cfdb5 into AlmasB:dev Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants