-
-
Notifications
You must be signed in to change notification settings - Fork 613
build: JavaFX 18 -> 19-ea+11, Kotlin 1.6.0 -> 1.7.10, attach 4.0.13 -> 4.0.15, jackson 2.12.1 -> 2.13.3 #1202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #1202 +/- ##
============================================
+ Coverage 58.60% 58.66% +0.05%
+ Complexity 2967 2960 -7
============================================
Files 303 303
Lines 14989 14993 +4
Branches 1536 1517 -19
============================================
+ Hits 8785 8796 +11
- Misses 5689 5692 +3
+ Partials 515 505 -10
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
so add else clause and return the compare result of modifier == NONE and also lift return to the place before when.
so add else clause and return false result and also lift return to the place before when.
is not available since 1.7 so use else clause to replace it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this, please can you have a look at the comments. Meanwhile, I'll check the logic behind isReleased()
and get back.
and also delete classifier of kotlin dependency
Sure, un necessary bumped plugins and test dependencies are reverted |
Looks good, ready for merge once |
because 0.8.7 doesn't support class file version 62 which is JDK 18 I tried to use jacoco 0.8.7 it throws out some warning exceptions telling me:Unsupported class file major version 62 So I think it would be better to upgrade jacoco plugin also
isReleased() is updated but we got another problem which may be caused by jacoco plugin version 0.8.7 Cheers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, many thanks
Hi:
We tried to bump the versions of dependencies and plugins
JavaFX from 18 -> 19-ea+10, it should be fine to change the final version to 19 since the JavaFX 19 is coming to the final release candidate, won't change too much
and JavaFX 19 has an important changes which is adding new .map and .flatMap method which would be really helpful for binding style programming
Kotlin from 1.6.0 -> 1.7.10
We have to remove the modular classifier of dependency of Kotlin-stdlib
since the incremental compilation is not experimental any more
and also another significant change in the code is that
@Suppress("NON_EXHAUSTIVE_WHEN") is not available since 1.7
non exhaustive when statement will cause compilation error
so use else clause to complete the when statement
and also bump the plugins' versions
The bumped version tests have passed in my computer

Cheers