Remove deprecated .getDOMNode() calls #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
HI @jrsquared , thanks your contributions :) but currently, I dont want to modify these depreacted api and merge into |
|
👍 |
1 similar comment
|
👍 |
|
Love to see it get merged! |
# Conflicts: # demo/js/demo.bundle.js # dist/react-bootstrap-table.min.js
jrsquared
changed the title
|
Updated the PR with changes from master... |
|
Hi @AllenFang, it looks like the project has a hard dependency on react 0.14.0, which means the changes to the dom node refs are already in place. @jrsquared's PR fixes the issue of getting a lot of warnings from calling Thanks for this very useful package and keeping it up to date! |
|
ok, I'll merge it first today, thanks your feedback :) |
AllenFang
added a commit
that referenced
this pull request
Oct 22, 2015
Remove deprecated .getDOMNode() calls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
React 0.14 does not need .getDOMNode() anymore, and it's use pollutes the console pretty heavily.