Skip to content

Milestone to v3.0.0 #497

Closed
Closed

Description

@AllenFang

v3.0.0

I'm going to start a plan for react-bootstrap-table@3.0.0, so I wonder if any ideas for v3.0.0, you can tell me in this threads. Anyway, I've considered some issues must be solve in v3.0.0(may not, it depend):

  1. Make all the components customizable(include pagination, insert button or modal etc.)
    There're the relative issues:
    How to make 'search input' float left?  #492, When you override the text of the Export CSV button it doesn't override the icon #469, Made glyphicons for toolbar buttons overridable #476, Expose 'Add' and 'Delete' button through refs. #356, can not support customize button #251, Custom table footer #172, Hide pagination size selector dropdown #487, How to hide pagination when there is only one page? #484, paginationShowsTotal custom text #462, Control position of components (pagination, export button, ...) #456, New and Delete button custom text #426 etc.
  2. Remove the column filter on bottom of table
  3. Remove the dependency for bootstrap.js

Feel free to give any suggestion or feedback. BTW, if u r interesting for contributing this repo, it's welcome

alpha todo list

Thanks
@AllenFang

Activity

  1. AllenFang commented on Jun 13, 2016

    @AllenFang
    OwnerAuthor

    @lbargery, I'm glad to hear your feedback.

    copy one/multiple rows

    it's a cool feature!

    import from CSV

    It's also a awesome feature, someone who has asked this feature but I just reject lol. but it's welcome to make a PR.

    custom rendered cells available in add dialog, modal dialog being popped up for cell edit

    that's why I want to bump to v3.0.0, it's a commons problem which a lots of user encounter.

  2. Amertz08 commented on Jun 21, 2016

    @Amertz08

    Possible to add #220 to it? Not sure what to call it maybe nested sorting? Multiple sorting? Anyway just a suggestion love what you have done so far just started using this in a project and it saved me a ton of time. Keep up the good work.

  3. AllenFang commented on Jun 21, 2016

    @AllenFang
    OwnerAuthor

    HI @Amertz08, for #220, I've no any plan to do it, I want to keep the sort simple and the sorting behavior in most table component does not support the nested sorting or something like that #220. Anyway, there's a lot of important thing need to be done, so I wont support #220 in near future, But PR is welcome 👍
    sorry sir

  4. inthedark122 commented on Jun 21, 2016

    @inthedark122

    Hello @AllenFang .
    Thank you for you good project. It very simple for using.
    I'm waiting for removing bootstrap.js from project 👍

  5. Amertz08 commented on Jun 22, 2016

    @Amertz08

    Possible to add a view all to the pagination? EDIT: realized there is an easy workaround for this.

  6. AllenFang commented on Jun 23, 2016

    @AllenFang
    OwnerAuthor

    @Amertz08, it's a much custom functionality for users. Maybe I will try to implement it. :)

    there is an easy workaround for this

    so what's that?

  7. mbaroukh commented on Jun 23, 2016

    @mbaroukh

    Hi,

    My suggestions:

    • have data not being only an array. It could be an array but it could also be an object which provide getCount() and getItem() (promise) methods so data loading could be lazy. In this case, of course, sorting/filtering should also be custom callbacks.
    • I had problems with the default "height=100%" : pagination was outside of the screen. Never found why. But I had to use "height=auto" and I wonder if it shouldn't be the default value
    • For custom buttons, there should be a way to ling them to selected data : the button is always clickable and expect no data OR the button can only be clicked if data is selected and expect the datas as a parameter .

    Also, I did not found any "developper" page which explain how to contribute, package, ... It may be obvious for javascript developpers, but I'm not and I need some time to understand.

    Tell us when you'll make the branch so we can contibute.

  8. abhirao commented on Jun 23, 2016

    @abhirao

    @AllenFang I need the ability to provide custom cell editors ( see #162)

    I'm going to start on a PR. Will model it after how the custom column filter components are implemented. Will ask for feedback on the interface before I get too far.

  9. Amertz08 commented on Jun 23, 2016

    @Amertz08
    class Parent extends React.Component {
        constructor(props) {
            super(props);
            this.state = {
                pagination: true
            };
        }
    
        _togglePagination() {
            this.setState({ pagination: !this.state.pagination });
        }
    
        render() {
            return (
                <div>
                    <button onClick={ ::this._togglePagination } >Toggle</button>
                    <BootstrapTable
                        pagination={this.state.pagination}>
                    </BootstrapTable>
                </div>
            )
        }
    }

    @AllenFang hacky but it worked.

  10. AllenFang commented on Jun 26, 2016

    @AllenFang
    OwnerAuthor

    @mbaroukh, I'll thinks about your suggestion, and will open a branch for v3.0.0. Sorry for lately reply, I'm busy on work ;(

  11. ssjogus commented on Jun 29, 2016

    @ssjogus

    hey thanks for the next versions. If we can have resizable columns , that will be great..

  12. ssjogus commented on Jun 29, 2016

    @ssjogus

    also one more wish -

    for filter: can we have a button, clicking on which the filter row opens up..

    something like attached screenshot. i did this using jquery.. but it will be good to have in the plugin itself..

    Screenshot1 - filter controls hidden
    image

    Screenshot2 - on click of icons in the header, the filter row opens
    image

  13. 73 remaining items

  14. StephReaves commented on Feb 25, 2017

    @StephReaves

    @AllenFang thanks for you work on react-bootstrap-table! I'm having issues with the modal in my local environment vs when deployed. When I click on the 'new' button when deployed to heroku nothing happens... There are no errors in the react dev tools. I'm using version 3.0.0 and have imported the css. When running the code on localhost everything works as expected - modal pops up when clicked. Any direction is greatly appreciated. Thanks in advance for your help.

  15. philjoseph commented on Feb 26, 2017

    @philjoseph

    Hi @AllenFang - We've start to use your amazing project and use currently 2.11. Is there a description of all additions of version 3? Do you recommend to stay on 2.11 until you officially release 3 or do you think beta 11 is stable enough ?
    Thanks for your great work and your advices ?

  16. AllenFang commented on Feb 26, 2017

    @AllenFang
    OwnerAuthor

    @StephReaves, could you please help me to confirm if you use the v2.x and deploy on heroku is work well?

    @philjoseph, I'm going to a travel and I'll update official note for v3.0.0. Actually, I think using the newest version is much better, it support keyboard navigation and customization. Anyway, you can try v3.0.0 and any feedback is welcome, if you dont like it, use v2.11.x is well, they all are stable.

    Thanks

  17. KalpanaPagariya commented on Feb 27, 2017

    @KalpanaPagariya

    HI AllenFang, You have released v3.0.0, but examples are still pointing to jquery and bootstrap. Can you please update the examples also? Like index.html still refers to jquery and bootstrap.

  18. StephReaves commented on Feb 27, 2017

    @StephReaves

    @AllenFang thanks for following up. Was able to get 3.0.0 working by changing some configurations in webpack. Thanks again!

    Just getting going with React and react-bootstrap-table and I have another question on customizing the modal through insert Row. Basically, I don't want all of the columns to be displayed in the modal. For instance in your basic example, I only will display Product Price as an input options, but not Product Name or Product Id. Would I go about doing this by addressing the insertRow {true} settings? Apologies, but I couldn't find anything related in the docs or in a google search.

    One other question, is there a faq or slack channel for react-bootstrap-table where I should be directing my questions?

  19. AllenFang commented on Mar 2, 2017

    @AllenFang
    OwnerAuthor

    Sorry for lately reply due to my long trip ;)

    @KalpanaPagariya, thanks for remind, I forgot it.

    @StephReaves
    I think you can do it by custom modal, you can control which input field can display on modal, feel free to ask me anything by opening issue on this repo :)

  20. Siyfion commented on Mar 9, 2017

    @Siyfion

    @AllenFang I know you've mentioned #220 before and you talked about nesting sorts, this isn't really the main issue as far as I can see. It seems to be a simple "third" state to the sorting, which is "none".

    In fact this is precisely what the table does currently if you have no default sort and haven't as-yet selected to sort by anything... It's just that after selecting one, you can't get "back" to the un-sorted state.

  21. XidongHuang commented on Jun 2, 2017

    @XidongHuang

    @AllenFang thanks your hard working bro!
    So are there any solutions about the wrapping of table header and cell?

    I tried like this:

    <BootstrapTable id='mdm-table' 
    
    containerStyle={{'marginTop': '1em', 'whiteSpace': 'normal', 'wordWrap': 'break-word'}} 
    
    data={data} striped hover search exportCSV condensed pagination options={this.options}>
    

    but only marginTop: 1em works.
    And it is not a good choice to change white-space: nowrap in react-bootstrap-table.min.css, so what should we do about it?

    Thanks again.

  22. AllenFang commented on Jun 5, 2017

    @AllenFang
    OwnerAuthor
  23. XidongHuang commented on Jun 5, 2017

    @XidongHuang

    @AllenFang Yes sir, that is what I want, thank you so much!
    But a short question here, is it necessary to separate those css styling for each column? Or I can set them in parent container <BootstrapTable /> for the whole table?

  24. AllenFang commented on Jun 6, 2017

    @AllenFang
    OwnerAuthor

    But a short question here, is it necessary to separate those css styling for each column? Or I can set them in parent container for the whole table?

    @XidongHuang You can give a try but I didn't try it before.

  25. christianbalderrama commented on Sep 26, 2017

    @christianbalderrama

    Hi @AllenFang! First and foremost is huge thanks for your library! We're using this library for some quite of time for all of our projects and it works perfectly!

    Just want to ask, is there any feature to export one or more CSV with one table? For instance the default exportCSV button is exporting the data that is display on the table but the other is exporting other data.

    I was trying to override the options by creating a button group just like this

    return ( <ButtonGroup> {props.exportCSVBtn} <ExportCSVButton btnText='Down CSV' onClick={ () => this.handleExportCSVParts() }/> </ButtonGroup> );

    However I was expecting that the data inside the handleExportCSVParts function will be exported, data type is array.

    Is there such this kind of feature export multiple CSV with one table? Huge thanks!

  26. AllenFang commented on Sep 27, 2017

    @AllenFang
    OwnerAuthor

    @christianbalderrama currently, we only can export the data from table. if you want to export some data, you can try to write yourself code for exporting csv, you can use filesaver and Blob to achieve your requirement. some example source code you can reference by https://github.com/AllenFang/react-bootstrap-table/blob/master/src/csv_export_util.js

    thanks

  27. koushindra commented on Feb 26, 2018

    @koushindra

    As I make remote={true}, filters on each column stopped working

  28. koushindra commented on Feb 26, 2018

    @koushindra

    How can I work with filter in remote pagination

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions