Skip to content

Comments

Fix/refactor into more components#89

Merged
ascibisz merged 7 commits intomainfrom
fix/refactor-into-more-components
Sep 25, 2025
Merged

Fix/refactor into more components#89
ascibisz merged 7 commits intomainfrom
fix/refactor-into-more-components

Conversation

@ascibisz
Copy link
Contributor

@ascibisz ascibisz commented Sep 17, 2025

Problem

Doing a bit of code cleanup, breaking out some new components and cleaning up some .css files

There should be no functionality changes! The website should behave exactly as before

@github-actions
Copy link

github-actions bot commented Sep 17, 2025

PR Preview Action v1.6.2
Preview removed because the pull request was closed.
2025-09-25 22:39 UTC

@ascibisz ascibisz marked this pull request as ready for review September 18, 2025 16:31
@ascibisz ascibisz requested review from Copilot and rugeli September 18, 2025 16:31
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors code by breaking out components from a monolithic App.tsx into smaller, focused components for better maintainability. The refactoring extracts StatusBar and RecipeForm components and removes some unused functionality while preserving all existing behavior.

  • Extracts StatusBar component from App.tsx to handle job status display and download functionality
  • Extracts RecipeForm component from PackingInput to handle form rendering and submission
  • Simplifies JSONViewer by removing external toggle state management and making it self-contained

Reviewed Changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/components/StatusBar/style.css New CSS file for StatusBar component styling
src/components/StatusBar/index.tsx New StatusBar component extracted from App.tsx
src/components/RecipeForm/style.css New CSS file for RecipeForm component styling
src/components/RecipeForm/index.tsx New RecipeForm component extracted from PackingInput
src/components/PackingInput/style.css Removed CSS rules that moved to other components
src/components/PackingInput/index.tsx Simplified by extracting RecipeForm and removing unused state
src/components/JSONViewer/style.css Updated width to work with new component layout
src/components/JSONViewer/index.tsx Simplified by making toggle state internal instead of external
src/components/InputSwitch/index.tsx Minor import reordering
src/components/GradientInput/index.tsx Removed unused state and added missing IDs for accessibility
src/App.tsx Simplified by extracting StatusBar component and removing duplicate logic
src/App.css Removed CSS rules that moved to StatusBar component

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@ascibisz ascibisz requested a review from interim17 September 18, 2025 16:33
Copy link
Contributor

@rugeli rugeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ascibisz ascibisz merged commit f58bf21 into main Sep 25, 2025
2 checks passed
@ascibisz ascibisz deleted the fix/refactor-into-more-components branch September 25, 2025 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants