Conversation
|
This reverts commit dd59630.
…pe/cellpack-client into feature/download-results # Conflicts: # src/App.tsx
…nto feature/download-results
ascibisz
reviewed
Sep 11, 2025
src/App.tsx
Outdated
| return fileNames; | ||
| }; | ||
|
|
||
| const downloadOutputsFromS3 = async (outputsDir: string, jobId: string) => { |
Contributor
There was a problem hiding this comment.
it may be good to make a new utils file for this download code? just to keep the App file a little more concise?
Contributor
Author
There was a problem hiding this comment.
good idea! updates:
- created an aws util file for s3 related functions
- moved s3 api path to constant file
ascibisz
approved these changes
Sep 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
What is the problem this work solves, including
closes #70
Solution
What I/we did to solve this problem
outputs_directoryfromjob_statusType of change
Please delete options that are not relevant.
Steps to Verify: