Merged
Conversation
|
ascibisz
force-pushed
the
maint/remove-landing-page
branch
from
281a915 to
e56ea43
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
We don't have the design for the landing page yet, and we don't have time to implement one, so for now we want the main url to route to the "packing page" and we don't want to link to the landing page.
Solution
NOTE: the landing page will still be reachable at /landing. I'm leaving it there for now just so we can keep all the code for routing that we previously worked on, as we will eventually be getting back to having a landing page.
Bonus: We had been experiencing some weird behavior with 404 errors when reloading the packing page, but that's gone now that it's at the "/" URL! We'll have to figure out why we were getting those errors later, but it's great to not have to deal with that this week :)