Conversation
|
f1db303 to
85fb02f
Compare
| <Slider | ||
| min={gradientStrengthData.min} | ||
| max={gradientStrengthData.max} | ||
| defaultValue={gradientStrengthData.default} |
There was a problem hiding this comment.
Tracing the code, I'm still a bit unclear about how this prop works. Seems like we're using value={sliderValue} to control the display value, and the actual reset happens through setSliderValue which looks for strengthData.default. If that's the case, this line defaultValue={gradientStrengthData.default} is ignored and we can just remove it?
There was a problem hiding this comment.
just tested and it seems like we can remove that!
- remove default value
rugeli
left a comment
There was a problem hiding this comment.
Looks good! Just have one question, but I don't see any other issues with values on the preview site. Approving now, we can always circle back for improvements or Q&A later as our time is tight. Great work on this!!
One small thing: would it be helpful to round the display gradient strength value?
for reference

Problem
Only certain fields of a recipe should be editable, not the whole JSON blob
Link to story or ticket
Solution
Editing the recipe should be like a form, with the editable fields that are specified in this spreadsheet
Some decisions I made, at least for now:
Type of change