Conversation
|
| .collapsible { | ||
| width: 450px; | ||
| margin-top: 5%; | ||
| } |
There was a problem hiding this comment.
it's not so great that I added .collapsible into two stylesheets for button, but I personally think it's fine for now because the design is not yet finalized and in this pr our focus is on components and style isolation. We'll likely want to have a shared button component with its own stylesheet to consolidate moving forward.
There was a problem hiding this comment.
I agree, making a button component is definitely in our future, so having this duplicate .collapsible code is temporary, and I don't think we need to bother worrying about it right now
|
Looking through the files, I feel there's room to further refactor some hooks out of |
src/components/Dropdown/index.tsx
Outdated
| {placeholder} | ||
| </option> | ||
| {Object.entries(options).map(([key, value]) => ( | ||
| <option key={key} value={value["firebaseId"]}> |
There was a problem hiding this comment.
nit: maybe we should make the "firebaseId" string a constant somewhere? I imagine we're intentionally setting this somewhere else. Obviously I know you just moved this code, you didn't write it in this PR, but I just noticed it
…nto feature/packing-input-refactor
2 participants
Problem
What is the problem this work solves, including
closes #54
Solution
What I/we did to solve this problem
DropdownandJSONViewercomponents and their stylesheetsapp.css:app.cssType of change
Please delete options that are not relevant.
Steps to Verify: