Skip to content

Comments

fix config id missing error#57

Merged
rugeli merged 1 commit intomainfrom
fix/config-name-in-filepath
Aug 7, 2025
Merged

fix config id missing error#57
rugeli merged 1 commit intomainfrom
fix/config-name-in-filepath

Conversation

@rugeli
Copy link
Contributor

@rugeli rugeli commented Aug 7, 2025

Problem

What is the problem this work solves, including
closes #46

Solution

What I/we did to solve this problem

  • updated firebase config to handle optional config selection

Thoughts: we can consider implementing proper input validation and type safety at the component level, so we don't have to do so much defensive programming patterns (e.g. configId ?).

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

@rugeli rugeli requested a review from ascibisz August 7, 2025 18:37
@github-actions
Copy link

github-actions bot commented Aug 7, 2025

PR Preview Action v1.6.2
Preview removed because the pull request was closed.
2025-08-07 23:23 UTC

@rugeli rugeli merged commit 49be3c5 into main Aug 7, 2025
1 check passed
@rugeli rugeli deleted the fix/config-name-in-filepath branch August 7, 2025 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Config name required in file path causing 400 error

2 participants