Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/recipeLoader.ts
Original file line number Diff line number Diff line change
Expand Up @@ -117,19 +117,19 @@ const resolveRefsInComposition = (

const stripFirebaseFields = <T extends { name: string; id: string; dedup_hash: string }>(
obj: T
): Omit<T, "name" | "id" | "dedup_hash"> => {
const { name, id, dedup_hash, ...viewable } = obj;
void name; void id; void dedup_hash; // Tell linter these are intentionally unused, we are "using" them by excluding them
return viewable as Omit<T, "name" | "id" | "dedup_hash">;
): Omit<T, "id" | "dedup_hash"> => {
const { id, dedup_hash, ...viewable } = obj;
void id; void dedup_hash; // Tell linter these are intentionally unused, we are "using" them by excluding them
return viewable as Omit<T, "id" | "dedup_hash">;
};

// reusable function for converting a collection of Firebase objects to a viewable format)
const convertCollectionToViewable = <T extends { name: string; id: string; dedup_hash: string }>(
collection: Dictionary<T> | undefined
): Dictionary<Omit<T, "name" | "id" | "dedup_hash">> => {
): Dictionary<Omit<T, "id" | "dedup_hash">> => {
if (!collection) return {};

const viewableCollection: Dictionary<Omit<T, "name" | "id" | "dedup_hash">> = {};
const viewableCollection: Dictionary<Omit<T, "id" | "dedup_hash">> = {};
for (const key in collection) {
viewableCollection[key] = stripFirebaseFields(collection[key]);
}
Expand Down
2 changes: 1 addition & 1 deletion src/types/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ export interface FirebaseRecipe {
gradients?: Dictionary<FirebaseGradient>;
};

export type Viewable<T extends { name: string; id: string; dedup_hash: string }> = Omit<T, "name" | "id" | "dedup_hash">;
export type Viewable<T extends { id: string; dedup_hash: string }> = Omit<T, "id" | "dedup_hash">;

export type ViewableComposition = Viewable<FirebaseComposition>;
export type ViewableObject = Viewable<FirebaseObject>;
Expand Down