break PackingInput and Viewer components out of App.tsx#47
Merged
Conversation
|
Closed
rugeli
reviewed
Jul 28, 2025
rugeli
reviewed
Jul 28, 2025
| } | ||
| return ( | ||
| <div> | ||
| <button className="collapsible" onClick={toggleLogs}>Logs</button> |
Contributor
There was a problem hiding this comment.
seems like this style is not been applied after the reorganization, we can go over all the class names to verify
Contributor
Author
There was a problem hiding this comment.
I just checked and the styling for "collapsible" is still being applied to the button, since it's in the parent component's .css file!
rugeli
reviewed
Jul 28, 2025
Merged
ascibisz
force-pushed
the
feature/break-out-components
branch
from
c9612c1 to
fffeee3
Compare
rugeli
approved these changes
Aug 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Pretty much everything other than firebase operations is happening in App.tsx. We probably don't want to continue this way.
Link to story or ticket
Solution
To start getting our repo organized, we are breaking out some basic components