Skip to content

Comments

github action for generating pr preview link#28

Merged
ascibisz merged 16 commits intomainfrom
feature/pr-preview-link
Jun 20, 2025
Merged

github action for generating pr preview link#28
ascibisz merged 16 commits intomainfrom
feature/pr-preview-link

Conversation

@ascibisz
Copy link
Contributor

@ascibisz ascibisz commented Jun 9, 2025

Problem

It would be good to have a PR preview link that is automatically generated when a cellpack-client PR is open for Thao to review for UX changes.

Link to ticket

Solution

  • Did something similar to the PR preview GitHub action in the Timelapse Colorizer repo (see here)
  • To get the PR preview action to work, I had to change a Github Pages setting so that the source for deploying Pages would be from the gh-pages branch. This broke the main website Github Pages build / deploy action, so I had to change that to something that would be compatible with the same settings

Type of change

  • New feature (non-breaking change which adds functionality)

@github-actions
Copy link

github-actions bot commented Jun 9, 2025

PR Preview Action v1.6.1
Preview removed because the pull request was closed.
2025-06-20 19:22 UTC

@ascibisz ascibisz linked an issue Jun 10, 2025 that may be closed by this pull request
@ascibisz ascibisz requested a review from rugeli June 17, 2025 20:12
@ascibisz ascibisz changed the base branch from fix/cors-issue-with-ecs to main June 20, 2025 18:35
@ascibisz ascibisz force-pushed the feature/pr-preview-link branch from 1293efa to d9903b2 Compare June 20, 2025 18:36
@ascibisz ascibisz merged commit a83f576 into main Jun 20, 2025
1 check passed
@ascibisz ascibisz deleted the feature/pr-preview-link branch June 20, 2025 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make a PR Preview Link Github Action

2 participants