Conversation
Coverage Report
File CoverageNo changed files found. |
|
rugeli
approved these changes
Nov 13, 2025
meganrm
approved these changes
Nov 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Ruge and I updated the one-sphere example in firebase today to match with the new version of the recipe that's zoomed in better that we're displaying by default.
I forgot we had tests making sure we're unpacking recipes properly and using the one-sphere recipe as an example, which needs to be updated if the one-sphere firebase recipe is changed.
Solution
Updating the one-sphere recipe loading tests to match with the changes we made in firebase today