Merged
Conversation
|
ascibisz
force-pushed
the
fix/input-styling
branch
from
7e10f12 to
683c386
Compare
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements several UI/UX improvements to align the interface more closely with the Figma design specifications. The changes focus on enhancing the visual clarity and usability of form inputs and sliders.
Key Changes:
- Moved units from after sliders to their labels for better visual organization
- Added min/max value labels below sliders, with descriptive "weak"/"strong" labels for the decay length slider
- Updated tab labeling from "Edit" to "Editable fields" for clarity
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/test/test-files/one_sphere.json | Updated test data bounding box coordinates and sphere radius to reflect new test values |
| src/test/recipeLoader.test.ts | Updated test assertions to match new bounding box coordinates and radius values |
| src/components/RecipeForm/style.css | Removed padding from recipe form container |
| src/components/PackingInput/index.tsx | Changed tab label from "Edit" to "Editable fields" |
| src/components/InputSwitch/style.css | Added styles for slider wrapper, min/max labels, and adjusted alignment and spacing |
| src/components/InputSwitch/index.tsx | Restructured slider markup to include min/max labels and moved units to the label area |
| src/components/GradientInput/style.css | Added styles for strength input container |
| src/components/GradientInput/index.tsx | Added min/max labels with "weak"/"strong" descriptors for the gradient strength slider |
| src/App.css | Reduced footer padding from 10px to 5px |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <small className="slider-label-left"> | ||
| {gradientStrengthData.min}<br /> weak | ||
| </small> | ||
| <small className="slider-label-right" style={{ marginRight: "5px" }}> |
There was a problem hiding this comment.
Inline styles should be avoided when possible. Consider moving this marginRight style to the CSS class definition for consistency with the rest of the codebase.
ascibisz
force-pushed
the
fix/input-styling
branch
from
e638144 to
c352a5c
Compare
ascibisz
force-pushed
the
fix/input-styling
branch
from
a3ce3ad to
bca7e93
Compare
meganrm
approved these changes
Nov 14, 2025
rugeli
approved these changes
Nov 14, 2025
Contributor
rugeli
left a comment
rugeli
left a comment
There was a problem hiding this comment.
tested things around and everything looks good on my end! (mainly speak from the visual/behavior side)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
There were a few things Thao had asked for that I hadn't gotten around to making tickets for because they were so small. One step towards getting closer to the figma doc
I did check in with Thao and she has approved this set of changes.
Solution