Merged
Conversation
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements autoselection of a default recipe ("peroxisome_v_gradient_packing") on application load. The implementation changes the recipe identification system from using display names to recipe IDs as the primary identifier throughout the application.
Key changes:
- Recipe selection now uses recipe IDs instead of display names as the primary identifier
- Default recipe is automatically selected in the initial state
- Display names are preserved for UI presentation in the dropdown
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/utils/firebase.ts | Refactored getPackingInputsDict to use recipe IDs as dictionary keys instead of names; code formatting improvements |
| src/types/index.ts | Added optional name field to PackingInputs type; formatting fixes |
| src/state/store.ts | Removed selectedInputName state, replaced with recipe ID-based selection; set default recipe ID; renamed selectInput to selectRecipe |
| src/components/PackingInput/index.tsx | Updated to use selectRecipe action and pass defaultValue to Dropdown |
| src/components/Dropdown/index.tsx | Modified to display names from PackingInputs and use recipe IDs as values |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ascibisz
approved these changes
Nov 5, 2025
rugeli
approved these changes
Nov 5, 2025
interim17
approved these changes
Nov 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
closes #117
Solution
added a recipe to the default state
I also removed the recipe display name from the store and am now only using the id as an identification. The only place the name shows up is in the dropdown
Type of change
Please delete options that are not relevant.
Change summary:
Steps to Verify: