Merged
Conversation
ascibisz
approved these changes
Feb 17, 2025
rugeli
added a commit
that referenced
this pull request
Feb 26, 2025
* setup build and deploy to github pages workflow * setup build and deploy to github pages workflow * add missing firebase dependency * add start script * try setting private to false * use different deploy action so we can specify folder * give permissions to action * try removing some steps that aren't included in documentation? * add setup pages step back * try breaking github pages stuff into two separate jobs * Revert "try removing some steps that aren't included in documentation?" This reverts commit eb9751a. * try to trigger new deploy * try breaking up github pages deploy into two steps * use valid upload-artifact version * use updated version of download artifact * change artifact name * add absolute path * revert accidental changes * Github Pages workflow is working here * try only givin gworkflow read access * set title to CellPACK * try doing build and deploy together, without upload / download steps * fix capitalization in cellPACK * try pulling out workflow_dispatch, since it's not doing anything * undo some of the chagnes to package.json from debugging * remove test branch, add blank line at end of file * use deploy-pages (#13) * use deploy-pages instead * fix path * remove testing branch from the workflow --------- Co-authored-by: Ruge Li <rugeli0605@gmail.com> Co-authored-by: Ruge Li <91452427+rugeli@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
What is the problem this work solves, including
Proposes switching to github's native
deploy-pagesaction for github pages deployment.closes #10
The deployment in pr #12 is working well. After digging around, I found that github recommends using
deploy-pagesso I'm giving it a try.Doc: https://github.com/marketplace/actions/deploy-github-pages-site
Solution
What I/we did to solve this problem
JamesIves/github-pages-deploy-action@v4withactions/deploy-pages@v4Pros:
Cons:
Type of change
Please delete options that are not relevant.
Steps to Verify:
main