Conversation
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
|
mogres
left a comment
mogres
left a comment
There was a problem hiding this comment.
Looks great!! Tested a golgi-endosome recipe on the preview site and it packed as expected!
src/utils/gradient.ts
Outdated
| const storeMin = opt.strength_min ?? 0; | ||
| const storeMax = opt.strength_max ?? 0.99; | ||
| const storeMin = opt.strength_min ?? 0.01; | ||
| const storeMax = opt.strength_max ?? 100; |
There was a problem hiding this comment.
nit: since we just defined MAX_GRADIENT_STRENGTH = 100, should we use that here?
There was a problem hiding this comment.
great catch! Updating it now
|
I'm noticing that the UI only allows you to input certain values, most notably that you can't input anything (via slider or the number input) between 50 and 100. It's kinda weird, and I think that's a bug worth fixing before we merge. I believe this is because we're clamping precision to 2 decimal points, so we can't have anything for decay_length in the store between 0.01 and 0.02, which translates in the UI to 100 and 50 |
ah I see! just updated it to store values with 4 decimals while keeping the UI display at 2 decimals, so the gap 50-100 is not a dead zone anymore. Thanks for testing! |
|
@rugeli can you convert this to a draft until you're ready for a re-review? |
|
closing this pr as we decided to go with the alternative approach for displaying gradient, merged in #133 |
4 participants
Problem
What is the problem this work solves, including
closes #99
Solution
What I/we did to solve this problem
decay_length = 1 / gradient strengthType of change
Please delete options that are not relevant.
Steps to Verify: