generated from allen-cell-animated/github-boilerplate
-
Notifications
You must be signed in to change notification settings - Fork 0
Closed
3 / 33 of 3 issues completedDescription
There are a few issues right now related to how we're handling recipe related data that we fetch from firebase
- For editable fields, we have the default values for each field saved in the
editable_fieldscollection. This is redundant, as it should match whatever is in that field for the recipe when loaded. If these values were to get out of sync, that would be a bug. To reduce that potential for bugs, we should read the values for each editable field that are in the recipe and populate that as the default (or just current) values - We currently have a
getCurrentValuehook in PackingInput, which is a work around to make sure we have the correct current value for gradient strengths when switching between gradients. This is kinda an anti-pattern, and it would be better to handle this differently. Perhaps by just storing the current value for each gradient, rather than just the default value? These changes could also be related to issue 1 above - We are currently loading each recipe from firebase every time a recipe is selected from the dropdown. We should probably just load them all on page load, and then store them locally. Along side this, we can decide whether or not it makes sense for changes that the user makes to persist between different recipe selections
Reactions are currently unavailable
Sub-issues
Metadata
Metadata
Assignees
Labels
No labels