Skip to content

20x alignment fixes and tests #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 27, 2022

Conversation

benjijamorris
Copy link

Pull request recommendations:

  • [x ] Name your pull request your-development-type/short-description. Ex: feature/read-tiff-files
  • [ x] Link to any relevant issue in the PR description. Ex: Resolves [Issue/size param automation #12], adds tiff file format support
  • [ x] Provide context of changes.
  • [x ] Provide relevant tests for your feature or bug fix.
  • [ x] Provide or update documentation for any feature added by your pull request.

Thanks for contributing!

This fixes a bug in 20x alignment that results in generation of all-nan alignment matrices regardless of input.

@GabeMedrash GabeMedrash self-requested a review July 13, 2022 21:19
Copy link
Contributor

@GabeMedrash GabeMedrash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@GabeMedrash GabeMedrash merged commit bf578c5 into AllenCell:main Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants