Changed crop-dims to 1800x1200 #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From discussion with assay-dev and microscopy, we are going with 1800x1200 for crop dims for 63x and 20x images.
GabeMedrash
suggested changes
Oct 5, 2021
Added comment on why the crop dimensions were chosen
GabeMedrash
suggested changes
Oct 5, 2021
GabeMedrash
approved these changes
Oct 6, 2021
| # - Use the line tool to measure the length of the largest regions of black pixels in the resulting image along each axis | ||
| # - Multiply those numbers by 2 and subtract from the minimum dimensions | ||
| return CroppingDimension(1828, 1224) | ||
| # The cropping dimensions for 63x and 20x were agreed upon by the microscopy committee on 9/4/2021: |
benjijamorris
approved these changes
Oct 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From discussion with assay-dev and microscopy, we are going with 1800x1200 for crop dims for 63x and 20x images.
Pull request recommendations:
Thanks for contributing!