Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI deprecation notices #385

Merged
merged 5 commits into from
Nov 11, 2024
Merged

Fix CI deprecation notices #385

merged 5 commits into from
Nov 11, 2024

Conversation

chrisib
Copy link
Collaborator

@chrisib chrisib commented Nov 9, 2024

Remove set-output, use GITHUB_OUTPUT instead. Should resolve #172

@roryjamesallen
Copy link
Collaborator

I have no idea how CI works so if you do and these changes fix the notices then LGTM

@chrisib
Copy link
Collaborator Author

chrisib commented Nov 11, 2024

I noticed a few more notices with the tests for this branch, so I'll try making a few more changes before merging.

@chrisib
Copy link
Collaborator Author

chrisib commented Nov 11, 2024

As of that last push, the only error left is

 build_and_publish / build-n-publish: # >> PyPA publish to PyPI GHA: POTENTIALLY INVALID TOKEN <<#L1

It looks like you are trying to use an API token to authenticate in the package index and your token value does not start with "pypi-" as it typically should. This may cause an authentication error. Please verify that you have copied your token properly if such an error occurs.

I don't think I have access to the PyPi credentials, so @roryjamesallen if this is a significant concern I think you'll need to dig into that. But the deprecation notices are all gone, which was the main purpose of this merge request.

@chrisib chrisib merged commit 91bd797 into Allen-Synthesis:main Nov 11, 2024
3 checks passed
@chrisib chrisib deleted the ci-fixes branch November 11, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] GitHub actions are using deprecated commands
3 participants