Make the missing-file warning less alarming when loading JSON data #372
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if the JSON configuration file is missing for any of
europi_config
,experimental_config
, or any individual script that uses theconfiguration.ConfigPoint
implementation, the user will see an error message like this:This can cause confusion for users, since it looks like it's an error they need to correct, when in fact they're just opting not to define a customization file to override the default settings. This MR handles
errno.ENOENT
("no entity") so instead the user will seeI considered just swallowing that error and not printing anything, but I think it's important to show that the file is failing to load just in case the user is trying to override something and e.g. accidentally put the file in the wrong directory or has an invalid capitalization inside the filename.
All other errors are handled as they are now, as those probably are bugs that should be addressed.