-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic support for large fonts - V2 #293
Conversation
Note: custom_font_demo.py should be removed from contrib before this PR is merged |
Thank you so much @roryjamesallen for having fixed and finished my work. That's very kind of you. |
Thank you! The work was almost completely finished, I only started working on it when I realised you'd done all the hard stuff already. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting the work into this @roryjamesallen. I had meant to take it over, but never found the time.
You are right that this seems pretty close to ready to merge. I've identified a couple of documentation changes, as well as some code changes that I think will make the future merge into the firmware easier. Let me know if any of my comments are confusing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just have one more documentation change to request and an optional suggestion to consider. After that it all looks good to me and is ready to merge from my point of view. Good work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for those doc changes. Looks good to me now.
This is a copy of all the work done by @francoisgeorgy in #234
I've completed all the changes requested since the most recent commits on the old branch, but there may well be other issues I'm not yet aware of. The
custom_font_demo.py
script does run and display correctly at least.