Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic support for large fonts - V2 #293

Merged
merged 15 commits into from
Sep 18, 2023
Merged

Basic support for large fonts - V2 #293

merged 15 commits into from
Sep 18, 2023

Conversation

roryjamesallen
Copy link
Collaborator

This is a copy of all the work done by @francoisgeorgy in #234

I've completed all the changes requested since the most recent commits on the old branch, but there may well be other issues I'm not yet aware of. The custom_font_demo.py script does run and display correctly at least.

@roryjamesallen
Copy link
Collaborator Author

Note: custom_font_demo.py should be removed from contrib before this PR is merged

@francoisgeorgy
Copy link

francoisgeorgy commented Aug 12, 2023

Thank you so much @roryjamesallen for having fixed and finished my work. That's very kind of you.
I still regret not having had the time to do it myself, but family issues and too much work have kept me so busy I haven't even had time to use my eurorack for the last months.

@roryjamesallen
Copy link
Collaborator Author

Thank you! The work was almost completely finished, I only started working on it when I realised you'd done all the hard stuff already.
I hope everything is well and you can get back to your modular soon:)

Copy link
Collaborator

@mjaskula mjaskula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting the work into this @roryjamesallen. I had meant to take it over, but never found the time.

You are right that this seems pretty close to ready to merge. I've identified a couple of documentation changes, as well as some code changes that I think will make the future merge into the firmware easier. Let me know if any of my comments are confusing.

software/firmware/experimental/custom_font.py Show resolved Hide resolved
software/firmware/experimental/custom_font.py Outdated Show resolved Hide resolved
software/firmware/experimental/custom_font.py Outdated Show resolved Hide resolved
software/contrib/custom_font_demo.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@mjaskula mjaskula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just have one more documentation change to request and an optional suggestion to consider. After that it all looks good to me and is ready to merge from my point of view. Good work.

software/firmware/experimental/custom_font.md Outdated Show resolved Hide resolved
software/firmware/experimental/custom_font.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@mjaskula mjaskula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for those doc changes. Looks good to me now.

@mjaskula mjaskula merged commit b8bc5c5 into main Sep 18, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants