Add quantizer UI improvements #245
Conversation
software/contrib/quantizer.py
Outdated
| "-Min 3", | ||
| "-Maj 2", | ||
| "-Min 2", | ||
| "Per 1", |
There was a problem hiding this comment.
Can you add a space before this one? Otherwise it's 1 column left from everything else, due to the + or - characters.
Overall, I'm ambivalent to the m|M vs Min|Maj notation. I think Pam's New Workout uses mi and MA for minor and major. If it makes things more usable for people with less music theory in their background that's fine with me.
There was a problem hiding this comment.
I've just added a commit that uses the 2 character naming, I think that's much neater than what I had before but still more obvious than just single letters (and nice to keep to the same style as a common module)
I believe the way the text is displayed handles the centering regardless of the length of characters, so the space would actually push it off-centre. Does it appear off-centre on your module?
There was a problem hiding this comment.
Accidentally commented while logged into the wrong account. Whoops!
I forgot the layout of the UI changed; I haven't actually had a chance to try it out yet. Since the text is all in a centered row, and isn't the old {old} <- {new} style, having all the options occupy the same horizontal space is less of a concern.
Two letters for the interval names is probably fine.
The menu in the Quantizer script wasn't quite intuitive enough for me to realise without RTFM that you need to press button 1 for the change to come into effect.
To remedy this, I've made some changes which now scroll all the options for each menu option, showing the current mode in inverted text (white block with black text), and the hovered option as outlined.
The hovered option is always in the middle of the screen so it's also very easy to see which one you will press when making a new change.
I have adjusted the octave range to be larger as the EuroPi can output larger ranges, and it might be useful to have more extreme transposition options.
I've also changed the text for the note transposition page to use longer contractions of the prefixes, for example 'Maj' instead of 'M' as I feel it's more readable. I understand this change is completely subjective as to its usefulness so I'll leave it up to @chrisib to decide if it's appropriate (or any of the other changes in this PR for that matter)
Example of the new selection screen: +2 is the current mode, and 0 is the hovered mode (0 will be applied if button 1 is pressed)
