Master clock

[gamecat69]

Initial PR for the master clock script. Includes adding the script to the main menu.
Also includes minor CV Recorder changes as these are not yet merged into the main upstream branch.

[mjaskula]

This looks really good. The only thing we need for merge, from my point of view, is an import fix to allow the menu test to pass.

One note. When I first tried using it, I thought it was broken, because I couldn't get the bpm to change. This was because I hadn't read the manual and didn't know about config mode, after that it made sense. This is all to say that there might be room for a more intuitive UI,

I left a few other suggestions and questions, but I look forward to using this.

[mjaskula]

[optional] The above section of code governing cv2-6 is just begging to be a for loop.

[gamecat69]

I can't intuitively think of a for loop that would be more efficient or easier to read. I am open to suggestions though,

[awonak]

I think it would require a bit more refactoring by putting the division outputs into a list instead of individual class attributes, then enumerating over them and europi.cvs:

for idx, output in enumerate(self.divisionOutputs):
  if output and self.step % output == 0:
    self.el.create_task(self.outputPulse(cvs[idx + 1])
  else if output == 0:
    cvs[idx + 1].value(randint(0, 1)

That would clean up other code sections like159-170

# Only adjust values if k2 has moved. This avoids a potentially annoying UX
if self.previousselectedDivision != selectedDivision:
    self.divisionOutputs[self.activeOption] = selectedDivision
    self.saveState()

self.previousselectedDivision = selectedDivision

Looking over all the instances of self.divisionOutputX, I think it's doable, but would be a bit of a significant change to the script.

[gamecat69]

Thanks. you were right the change was significant, but doing this streamlined a few other areas too! Done!

[roryjamesallen]

Really looking forward to having this script in my rack

Just need to resolve the conflicts and then LGTM

[gamecat69]

Suggested changes made and merge conflicts resolved - let's merge ASAP!

[roryjamesallen]

It looks like the Turing machine has been accidentally removed and master clock not imported from the contrib folder, I think that's the only thing failing now!

[djmjr]

Awesome work everyone! I think this script is an awesome addition to the EuroPi ecosystem!