[pull] master from web-platform-tests:master #1763
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch ensures the toggle event is dispatched for the details element after the document load finishes. I suspect this test was timing out because the toggle event was fired before the document loaded when running in headless mode, which resulted in ReferenceError for child elements (`a` or `b`). Bug: 465614980 Change-Id: Ia52e63939d0f59cee6088d849d459a09feb81bcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7237758 Commit-Queue: Ashish Kumar <ashishkum@microsoft.com> Reviewed-by: Rohan Raja <roraja@microsoft.com> Reviewed-by: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/main@{#1556530}
…mDoc data (#56352) * Digital Credentials: implement CANONICAL_REQUEST_OBJECTS with actual mDoc data - Add CANONICAL_REQUEST_OBJECTS with real mDoc deviceRequest and encryptionInfo data - Update factory functions to use canonical objects as defaults with data spread - Refactor internal architecture with new buildRequests and makeOptionsInternal helpers - Make mediation optional in type definitions (no longer defaults to 'required') - Add comprehensive data parameter support to config interfaces - Complete property bag + signal + protocol selection + canonical objects integration * Digital Credentials: Simplify helper function architecture and add requests parameter - Add requests parameter to MakeGetOptionsConfig and MakeCreateOptionsConfig interfaces - Replace complex makeOptionsUnified/makeOptionsInternal system with simpler makeCredentialOptionsFromConfig - Convert buildRequestsFromProtocols to functional programming approach using .map() - Remove factory functions (makeOID4VPDict, makeMDocRequest) in favor of inline functions in allMappings - Make mediation optional in CredentialRequestOptions and CredentialCreationOptions - Enhance TypeScript annotations with generics for better type safety - Support empty protocol arrays (protocol: []) for testing scenarios - Clean up unused imports and improve documentation alignment * Add data parameter to config interfaces and update tests to use clean data override pattern - Add data parameter to MakeGetOptionsConfig and MakeCreateOptionsConfig for overriding canonical data - Wire explicitData parameter through buildRequestsFromProtocols call chain properly - Update tests to use clean makeGetOptions({data}) pattern instead of manual object construction - Replace post-construction data manipulation with clean data override during construction - Maintain separation of concerns: protocol selection automatic, data override optional
…to the BiDi client. Differential Revision: https://phabricator.services.mozilla.com/D275230 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1944568 gecko-commit: 38c56db844043d8ee13479d6172df52ff69d5d86 gecko-reviewers: jgraham, jdescottes
…ions. Differential Revision: https://phabricator.services.mozilla.com/D275231 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1944568 gecko-commit: e8757a81c14893a58dd6f294ddc725e56e28d418 gecko-reviewers: jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D275446 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=2004407 gecko-commit: 2fd1e0d421ace8296f1bc1379cdff55a76845995 gecko-reviewers: smaug
…lank. " for causing wpt failures @coep-blob-popup.https.html. This reverts commit 2fe2da3e4b00a6f242e68aa97c519034c4f304c0. Revert "Bug 2004407 - Get policy container for initial about:blank from entry global. r=smaug" This reverts commit dbad5d1e6bb41cfe17061a0258a872ac7a642a8c. gecko-commit: 803b3a0fc050acf1e58b6e81b5604528cb480b31 gecko-reviewers: smaug
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )