[pull] master from web-platform-tests:master #1748
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In addition to unconditional scrollbars, we also have to subtract any gutters from the viewport size because they also unconditionally take up space. Gutters only take up space in the inline direction, so we have to check the resolved writing mode property now. Bug: 354751900 Change-Id: I07f1d9cd467e3c872da65d4ea709a21b14507c10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7226421 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/main@{#1554127}
`backdrop-filter` rendering is clipped by the element’s border radii. Previously, updates to border-radius did not trigger a paint property update for elements with non-initial `backdrop-filter`. This patch adds a check for `BorderRadiusChanged` when the element has a non-initial `backdrop-filter` and marks the element as needing a paint property update. This keeps the filter bounds consistent with the visual clipping. Bug: 447660343 Change-Id: Ie019a22f54c1cebc9163282645355f74d8e2766d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7223670 Commit-Queue: Peng Zhou <zhoupeng.1996@bytedance.com> Reviewed-by: Philip Rogers <pdr@chromium.org> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/main@{#1554162}
Bug: 463393319 Change-Id: Ie67714db5b8d49ae87597959433fd79c89547346 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7224470 Reviewed-by: Vladimir Levin <vmpstr@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/main@{#1554198}
and fixing the tests Bug: 446157737 Change-Id: I4f86bd721fcb69d18c7070dd264eacf1df9dee34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7224767 Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Cr-Commit-Position: refs/heads/main@{#1554219}
Add a state stack. We couldn't trust ShouldForceEntireSubtreeUpdate() to return the same value upon entry as upon exit, since SetShouldCheckForPaintInvalidation() might be called on a descendant in the meantime (and propagated up the tree). force_entire_subtree_update_ in TraversalListener ended up as negative, because the result of ShouldForceEntireSubtreeUpdate() wasn't the same upon entry (false) and exit (true). This caused a DCHECK failure. `DCHECK_GE(force_entire_subtree_update_, 0)` This particular case does seem benign, but the CL is also a speculative "fix" for the real crash in crbug.com/464464623 (not been able to reproduce it). Bug: 464464623 Change-Id: I3d942d71930762ab7db73297567b722e28a06312 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7221490 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/main@{#1554230}
As per resolution in w3c/csswg-drafts#13037 (comment) Shadows should be border-aligned, like border inset, with external "miters" that are clipped to the outer edge. The miter is computed by extending the start and end tangents of the curve until they reach the outer edge. The tangent is the line between the start point, and the "control point": a point that would be the quadratic control point if this was a normal quadratic curve with the same half-corner. As part of this work, refactoring the rendering tests to be both more precise and closer to something that can be reasoned about being close to the spec. See spec PR: w3c/csswg-drafts#13173 The PR and the WPT rendering code were developed side by side to ensure that the tests assert the spec. Since the spec defines that curves are approximate, and ref tests can fail on antialiasing and curve inaccuracies, the corners are also stroked with a blue 3px line on both the actual and ref versions, to avoid test failures in these occasions. (This change is guarded by the BorderRadiusCorrectionCoverageFactor, as without it shadow rects wouldn't have an origin rect, so the changed code paths is never reached). Bug: 463996869 Change-Id: I7f586440f47757416b8eb9a2002629cd29e0174a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7215437 Reviewed-by: Philip Rogers <pdr@chromium.org> Commit-Queue: Noam Rosenthal <nrosenthal@google.com> Cr-Commit-Position: refs/heads/main@{#1554276}
Document::DOMWindow is not always available, for example when parsing via Document.parseHTMLUnsafe. This change adds an early return to prevent crashing. This means declarative modules won't work via Document.parseHTMLUnsafe, but that matches the behavior of imperative modules. I added a TODO to follow up with the WHATWG about this. A test was added that crashes without the fix. Bug: 448174611 Change-Id: I471d397fd730385d16eaef231c3cb8c369230597 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7214509 Reviewed-by: Mason Freed <masonf@chromium.org> Commit-Queue: Kurt Catti-Schmidt <kschmi@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1554428}
Feature: local-network-access Reference: https://github.com/web-platform-dx/web-features/blob/main/features/local-network-access.yml Notable exclusions 1. `fenced-frame/disallowed-navigation*` - These tests use local-network-access resources (support.sub.js) to verify Fenced Frame navigation restrictions
…o bidi test client. Differential Revision: https://phabricator.services.mozilla.com/D273427 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=2000651 gecko-commit: 16c277a84b48f161858cd29272acddf77ee4eec3 gecko-reviewers: jgraham, whimboo
Differential Revision: https://phabricator.services.mozilla.com/D273428 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=2000651 gecko-commit: 9dc7dba7964c5176b38a37b4340e9a6809ce33fd gecko-reviewers: whimboo
…on.setLocaleOverride". Differential Revision: https://phabricator.services.mozilla.com/D275042 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=2003992 gecko-commit: bb12eb0a09f7fecc2b10e5c874985a3261b706ec gecko-reviewers: whimboo
I caught a typo with this. Tests are good to have. Differential Revision: https://phabricator.services.mozilla.com/D272806 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=2000448 gecko-commit: 0ef74cd8fdb518c476c59ca666c04e5284e67b25 gecko-reviewers: whimboo, geckodriver-reviewers, jgraham
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )