[pull] master from web-platform-tests:master #1733
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Tejas Dhagawkar <tdhagawkar@microsoft.com>
Signed-off-by: Josh Matthews <josh@joshmatthews.net>
This reverts commit 709cf5c977c287723630f2b4e8a521e0c2067f3e. Reason for revert: perf regressions, null ptr deref Original change's description: > Implement border-shape hit testing > > So far it's specified not to affect layout, but we want it to be > hit-testable. Existing hit-testing code normally does a simple border > box check first before going into any clipping details inside, but, > since the border-shape can be painted outside the border box, we need > to check its border-shape bounding box for hit-testing. > > To do so, and also not to lose the border when the shape is painted > outside the viewport, this CL computes scrollable (layout) overflow > and uses that box for hit-testing purposes. That box is propagated up, > meaning all the ancestors will now account for scrollable overflow > of a descendant element with border-shape. > > The hit test of PaintLayer will be done in the follow-up and tracked > in crbug.com/456675133 > > Bug: 370041145 > Change-Id: I9f548620db37732c198243940325216c85e8f34e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6862996 > Reviewed-by: Philip Rogers <pdr@chromium.org> > Commit-Queue: Daniil Sakhapov <sakhapov@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1550496} Bug: 370041145 Change-Id: Ie22c2cacb595e01119e32cc07f6ab0acf385117e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7208865 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Daniil Sakhapov <sakhapov@chromium.org> Reviewed-by: Steinar H Gunderson <sesse@chromium.org> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/main@{#1551401}
See also initial-about-blank.window.js which this test is now aligned with.
Co-authored-by: wpt-pr-bot <wpt-pr-bot@users.noreply.github.com> Stability results seem unrelated.
…perspective properties. Added tests for invalid `transform` and `perspective` properties, and unitless valid tests for their `-webkit-` counterparts Bug 1362499 - Added tests for invalid tests for transform and perspective, and valid ones for their webkit counterparts. r?emilio - Added invalid unitless `calc()` test for `-webkit-perspective` - Updated `property_database.js` to pass mochi tests Differential Revision: https://phabricator.services.mozilla.com/D274128 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1362499 gecko-commit: 02434507f7aa5ab7cba9894e22b9815d94ff2837 gecko-reviewers: emilio, firefox-style-system-reviewers
The Offscreen and Worker version of these tests already have their size set, but the HTMLCanvasElement tests were using the default canvas size. This difference could cause issues, with the HTMLCanvasElement test behaving unexpectedly. Change-Id: I826ded56843acadf231c778d4ef4abe99b6eed5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7210510 Reviewed-by: Andres Ricardo Perez <andresrperez@chromium.org> Commit-Queue: Jean-Philippe Gravel <jpgravel@chromium.org> Cr-Commit-Position: refs/heads/main@{#1551634}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )