[pull] master from openssl:master #316
Merged
+24
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recently, the addition of some vector register save restore logic from: #28990 Triggered an issue in our quic_multistream_test, notably causing a connection shutdown with error code 1, rather than successful completion. The problem has been root caused to an error in how the ppc aes code saves and restores vector registers. The aes gcm code uses VSR instructions (vsldoi, etc), to maniuplate vector registers, which only operate on the upper half of the vector register file (VS32-63), and operands are implicitly offset to do this. (i.e. <instr> v31 actually operates on register vs63). However, the SAVE/RESTORE macros which save and restore those values use stxv/lxv instructions to do the save and restore, which are VSX instructions that have access to the full vector register file, and so by restoring V1, rather than V33, etc, we actuall restore values to the wrong registers, causing various issues (most notably the above misconfiguration of the quic SSL shutdown event, which sets the error code erroneously to 1 instead of the expected 0 value). Fix it by offsetting the SAVE_REGS and RESTORE_REGS macros to reference the proper registers when doing save and restore. Fixes #29516 Reviewed-by: Saša Nedvědický <sashan@openssl.org> Reviewed-by: Tim Hudson <tjh@openssl.org> (Merged from #29528)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )