[pull] master from openssl:master #297
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Its been reported that, when using SSL_listen_ex to obtain a new connection from a listener, that, if the listener is freed prior to the obtained connection, we get use-after-free conditions when freeing said obtained connections. This occurs because SSL_listen_ex fails to take a reference on the parent listener SSL object (in the same way that SSL_new_from_listener does). If the listener is freed first, then several listener resources are freed, which the obtained connection still makes use of, hence the use-after-free. The fix is to do what SSL_new_from_listener does, namely: 1) Increase the reference count on the listener SSL object. 2) Ensure that the connection qc->listener points to the listener object so that, when the connection is freed, we call SSL_free on the listener object, dropping the reference count we take in SSL_listen_ex. While we're at it, this PR also modifies the quicapi test for testing the SSL_listen_ex call, freeing the listener first to ensure that the increased refcount holds the SSL object data stable until the connection is freed. Thanks to Stanislav Fort at Asile Research for pointing out this issue. fixes openssl/project#1766 Reviewed-by: Saša Nedvědický <sashan@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from #29398)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )