Skip to content

Commit

Permalink
feature: use posix_spawn on macos (ocaml#8090)
Browse files Browse the repository at this point in the history
Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
  • Loading branch information
rgrinberg authored Aug 8, 2023
1 parent d997dbe commit be9aa28
Show file tree
Hide file tree
Showing 4 changed files with 299 additions and 88 deletions.
2 changes: 2 additions & 0 deletions doc/changes/8090.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- Use `posix_spawn` instead of `fork` on MacOS. This gives us a performance
boost and allows us to re-enable thread. (#8090, @rgrinberg)
2 changes: 1 addition & 1 deletion src/dune_config/config.ml
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ let copy_file =

let background_default =
match Platform.OS.value with
| Linux | Windows -> `Enabled
| Linux | Windows | Darwin -> `Enabled
| _ -> `Disabled
;;

Expand Down
Loading

0 comments on commit be9aa28

Please sign in to comment.